fix: query ffmpeg for encoders and only list the ones we recognize and are available

This commit is contained in:
2024-12-20 21:51:05 +02:00
parent 206a62ee76
commit 5e74d10409
3 changed files with 43 additions and 6 deletions
+1 -1
View File
@@ -1,4 +1,4 @@
- [ ] query ffmpeg binary for available encoders and list the ones we know - [x] query ffmpeg binary for available encoders and list the ones we know
- [ ] when passing in a directory, list all video files in that directory and have the user choose which ones they want encoded - [ ] when passing in a directory, list all video files in that directory and have the user choose which ones they want encoded
- This will of course have a select all checkbox for quickly encoding all the files in a dir. - This will of course have a select all checkbox for quickly encoding all the files in a dir.
- [ ] calculate total progress based on file sizes instead of counts of files for a more accurate progress percentage. - [ ] calculate total progress based on file sizes instead of counts of files for a more accurate progress percentage.
+16 -3
View File
@@ -55,13 +55,26 @@ func initialModel(fileInfo os.FileInfo, absolutePath string) *model {
s.Spinner = spinner.Dot s.Spinner = spinner.Dot
s.Style = lipgloss.NewStyle().Foreground(lipgloss.Color("205")) s.Style = lipgloss.NewStyle().Foreground(lipgloss.Color("205"))
codecs, err := exec.Command("ffmpeg", "-encoders").Output() codecsStr, err := exec.Command("ffmpeg", "-encoders").Output()
if err != nil { if err != nil {
log.Println(err) log.Println(err)
} }
// TODO: parse the codecs and get the one we care about. codecs := strings.Split(strings.Split(string(codecsStr), " ------\n")[1], "\n")
log.Println(strings.Split(strings.Split(string(codecs), " ------\n")[1], "\n"))
for i, codec := range codecs {
if codec == "" {
continue
}
codecs[i] = strings.Fields(codec)[1]
// hardcoded indexes are never bad YEP :)))
if contains(SupportedVideoEncoders, codecs[i]) {
Configs[2].Opts = append(Configs[2].Opts, codecs[i])
} else if contains(SupportedAudioEncoders, codecs[i]) {
Configs[3].Opts = append(Configs[3].Opts, codecs[i])
}
}
return &model{ return &model{
IsDirectory: fileInfo.IsDir(), IsDirectory: fileInfo.IsDir(),
+26 -2
View File
@@ -2,11 +2,25 @@ package main
import "fmt" import "fmt"
var SupportedVideoEncoders = []string{
"libx264",
"libx265",
"libvpx-vp9",
"librav1e",
"libsvtav1",
}
var SupportedAudioEncoders = []string{
"aac",
"libopus",
"libvorbis",
}
var Configs = []Config{ var Configs = []Config{
{Name: "Delete old video(s)?", Opts: []string{"No", "Yes"}, FocusedOption: 1}, {Name: "Delete old video(s)?", Opts: []string{"No", "Yes"}, FocusedOption: 1},
{Name: "What should we do about encoded videos?", Opts: []string{"Skip", "Delete and encode again"}}, {Name: "What should we do about encoded videos?", Opts: []string{"Skip", "Delete and encode again"}},
{Name: "Video Encoder", Opts: []string{"copy", "libx264", "libx265", "libvpx-vp9", "librav1e", "libsvtav1"}}, {Name: "Video Encoder", Opts: []string{"copy"}},
{Name: "Audio Encoder", Opts: []string{"None", "copy", "aac", "libopus"}, FocusedOption: 1}, {Name: "Audio Encoder", Opts: []string{"None", "copy"}, FocusedOption: 1},
{Name: "Preset", Opts: []string{"ultrafast", "superfast", "veryfast", "faster", "fast", "medium", "slow", "slower", "veryslow"}, FocusedOption: 4}, {Name: "Preset", Opts: []string{"ultrafast", "superfast", "veryfast", "faster", "fast", "medium", "slow", "slower", "veryslow"}, FocusedOption: 4},
{Name: "Constant Rate Factor (CRF)", Opts: []string{"10", "15", "20", "25", "30", "35", "40", "45", "50"}, FocusedOption: 4}, {Name: "Constant Rate Factor (CRF)", Opts: []string{"10", "15", "20", "25", "30", "35", "40", "45", "50"}, FocusedOption: 4},
} }
@@ -54,6 +68,16 @@ cfgloop:
return filtered return filtered
} }
func contains[T comparable](slice []T, elem T) bool {
for _, e := range slice {
if e == elem {
return true
}
}
return false
}
func getVisibleConfigs(cfgs []Config) []Config { func getVisibleConfigs(cfgs []Config) []Config {
parsed := parseConfig(cfgs) parsed := parseConfig(cfgs)